Add tests for invalid variant metadata and value #7885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
force-pushed
the
add_invalid_object_test
branch
from
c328d89 to
1a3ac22
Compare
viirya
force-pushed
the
add_invalid_object_test
branch
from
1a3ac22 to
3878891
Compare
alamb
approved these changes
Jul 9, 2025
friendlymatthew
approved these changes
Jul 9, 2025
Contributor
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
This looks great. Thank you @viirya
mbrobbel
approved these changes
Jul 9, 2025
scovich
reviewed
Jul 9, 2025
Comment on lines
+544
to
+545
| assert!(err.is_err()); | ||
| let err = err.unwrap_err(); |
Contributor
There was a problem hiding this comment.
nit: assert! and unwrap_err will both panic if the result is not an error. Seems redundant?
(above as well)
Contributor
There was a problem hiding this comment.
let's maybe clean it up in a follow on PR
Member
Author
There was a problem hiding this comment.
Oh, you meant to remove assert!(err.is_err());? Yea, let's remove it later.
Contributor
There was a problem hiding this comment.
yeah, maybe we can make a follow on PR
Contributor
|
Thanks everyone! |
Member
Author
|
Thanks @alamb @friendlymatthew @mbrobbel @scovich |
alamb
added a commit
that referenced
this pull request
Jul 11, 2025
# Which issue does this PR close? None # Rationale for this change Address the comment #7885 (comment). # What changes are included in this PR? Remove redundant `is_err` checks. # Are these changes tested? Existing tests. # Are there any user-facing changes? None Co-authored-by: Liang-Chi Hsieh <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Added new tests for invalid variant metadata and value.
Are these changes tested?
Yes, added new tests.
Are there any user-facing changes?
No